Fix nullification of has_many :through association with `query_constraints

[nvasilevski]

Given a has_many :through association with query_constraints:

BlogPost.has_many :posts_tags BlogPost.has_many :tags, through: :posts_tags, query_constraints: [:blog_id, :post_id]

It is possible to nullify the association like blog_post.tags = []
which results in deletion of records from the posts_tags joining table.

Implementation details

The test we added fails on main with NoMethodError: undefined method to_sym for ["blog_id", "id"]:Array on the line

rails/activerecord/lib/active_record/associations/through_association.rb

Line 66 in d53dc86

source_reflection.foreign_key => records.map(&association_primary_key.to_sym)

However this failure is misleading as we shouldn't be reaching this line at all, at least for the test we built.
In our case the issue lies a few lines above, at:

rails/activerecord/lib/active_record/associations/through_association.rb

Line 62 in d53dc86

if association_primary_key == reflection.klass.primary_key && !options[:source_type]

Since the introduction of query_constraints in associations association_primary_key can be an array while primary_key may not necessarily be an array in case if the model uses virtual query_constraints definition. So essentially we need to compare association_primary_key with query_constraints_list if it is not empty and only then compare it with a primary key. To avoid branching I've introduced a new internal concept - composite_query_constraints_list this is an always non-empty array of query constraints that either equals to manually configured query_constraints or to the primary_key wrapped in an array. This concept will be useful in the future in internal codeplaces that are ready to work with an array of columns to avoid unnecessary branching.

After comparing primary keys as Arrays the logic follows into the branch and queries the records by the association name which has already been fixed in #47692

We still need to address the else branch but for this we will need to extend our Sharded fixtures to have an association with a custom source_type or query_constraints: configuration different from the parent's query_constraints

[eileencodes]

@nvasilevski can you take a look at the test failures?

[eileencodes]

This documentation needs improvement, it's a bit more wordy than we need here. Can you replace it with something like

Returns an array of column names to be used in queries. The source of column names is derived from +query_constraints_list+ or +primary_key+. This method is for internal use when the primary key is to be treated as an array. 

[nvasilevski]

Changed

[nvasilevski]

can you take a look at the test failures?

Should be fixed now, I shouldn't have wrapped association_primary_key into an array for the whole flow. At this moment we should only wrap for the comparision