Replace deprecated use of Event.initevent has been deprecated with Event constructor in activestorage.js #47707
+9 −6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…mozilla.org/en-US/docs/web/api/event/initevent Replace and make use of Event constructor instead. https://developer.mozilla.org/en-US/docs/Web/API/Event/Event
skipkayhil approved these changes Mar 18, 2023
| const { disabled } = element | ||
| const { bubbles, cancelable, detail } = eventInit | ||
| const event = document.createEvent("Event") | ||
| const event = new Event(type, {bubbles: bubbles || true, cancelable: cancelable || true}) |
There was a problem hiding this comment.
Not related to the change at hand: would it be possible to pass anything other than true for bubbles and cancelable? Seems like falsey values would always get overriden
There was a problem hiding this comment.
Aah, that is true. I just din't want to change from existing values and keep the code same as before 😅
For backwards compat.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Usage of
Event.initeventhas been deprecated - https://developer.mozilla.org/en-US/docs/web/api/event/initeventReplace and make use of
Eventconstructor instead- https://developer.mozilla.org/en-US/docs/Web/API/Event/EventDetail
Event.initeventanddocument.createEvent("Event")with simplifiedEventconstructor insteadChecklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]