Skip to content

Added ability to resize email previews for better testing + ability t… #45993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added ability to resize email previews for better testing + ability t… #45993

wants to merge 1 commit into from

Conversation

@igorkasyanchuk
Copy link
Contributor

@igorkasyanchuk igorkasyanchuk commented Sep 10, 2022 •
edited
Loading

Motivation / Background

The motivation is to add the ability to test email previews on the different resolutions, plus an easier way to see the source of the email.

image

image

image

Since we are showing "iframe" with email content, with these changes we just changing the width of it.

Detail

This Pull Request changes [REPLACE ME]

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • There are no typos in commit messages and comments.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Feature branch is up-to-date with main (if not - rebase it).
  • Pull request only contains one commit for bug fixes and small features. If it's a larger feature, multiple commits are permitted but must be descriptive.
  • Tests are added if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.
  • PR is not in a draft state.
  • CI is passing.
@rails-bot rails-bot bot added the railties label Sep 10, 2022
@igorkasyanchuk igorkasyanchuk force-pushed the resize_email_preview branch 4 times, most recently from fc0e3fb to bf20764 Compare September 10, 2022 09:54
@fatkodima
Copy link
Member

fatkodima commented Sep 10, 2022

Should we incorporate this feature into the Rails itself? 🤔 Because this is already available in browsers, like Chrome Dev Tools.
Screen Shot 2022-09-10 at 18 01 26
skipkayhil
skipkayhil reviewed Sep 10, 2022
View reviewed changes
railties/lib/rails/templates/rails/mailers/email.html.erb

<div id="controlView">
<a class="active controlItem" href="#" onclick="swithToDesktop(this); return false">
<img title="Desktop View (600px)" height="32" src="data:image/svg+xml;base64,PD94bWwgdmVyc2lvbj0iMS4wIiA/PjwhRE9DVFlQRSBzdmcgIFBVQkxJQyAnLS8vVzNDLy9EVEQgU1ZHIDEuMS8vRU4nICAnaHR0cDovL3d3dy53My5vcmcvR3JhcGhpY3MvU1ZHLzEuMS9EVEQvc3ZnMTEuZHRkJz48c3ZnIGVuYWJsZS1iYWNrZ3JvdW5kPSJuZXcgMCAwIDQ4IDQ4IiBoZWlnaHQ9IjQ4cHgiIHZlcnNpb249IjEuMSIgdmlld0JveD0iMCAwIDQ4IDQ4IiB3aWR0aD0iNDhweCIgeG1sOnNwYWNlPSJwcmVzZXJ2ZSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayI+PGcgaWQ9IkV4cGFuZGVkIj48Zz48Zz48cGF0aCBkPSJNNDQsNDJINGMtMi4yMDYsMC00LTEuODc0LTQtNC4xNzdWOC4xNzdDMCw1Ljg3NCwxLjc5NCw0LDQsNGg0MGMyLjIwNiwwLDQsMS44NzQsNCw0LjE3N3YyOS42NDYgICAgIEM0OCw0MC4xMjYsNDYuMjA2LDQyLDQ0LDQyeiBNNCw2QzIuODk3LDYsMiw2Ljk3NywyLDguMTc3djI5LjY0NkMyLDM5LjAyMywyLjg5Nyw0MCw0LDQwaDQwYzEuMTAzLDAsMi0wLjk3NywyLTIuMTc3VjguMTc3ICAgICBDNDYsNi45NzcsNDUuMTAzLDYsNDQsNkg0eiIvPjwvZz48Zz48cGF0aCBkPSJNMzgsNDZIMTBjLTAuNTUyLDAtMS0wLjQ0OC0xLTFzMC40NDgtMSwxLTFoMjhjMC41NTIsMCwxLDAuNDQ4LDEsMVMzOC41NTIsNDYsMzgsNDZ6Ii8+PC9nPjxnPjxwYXRoIGQ9Ik0yNCw0NmMtMC41NTIsMC0xLTAuNDQ4LTEtMXYtNGMwLTAuNTUyLDAuNDQ4LTEsMS0xczEsMC40NDgsMSwxdjRDMjUsNDUuNTUyLDI0LjU1Miw0NiwyNCw0NnoiLz48L2c+PGc+PGNpcmNsZSBjeD0iMjQiIGN5PSIzNyIgcj0iMiIvPjwvZz48Zz48cmVjdCBoZWlnaHQ9IjIiIHdpZHRoPSI0NiIgeD0iMSIgeT0iMzIiLz48L2c+PC9nPjwvZz48L3N2Zz4="/>
Copy link
Member

@skipkayhil skipkayhil Sep 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also interested in the source of these icons. Where do they come from and what license do they have?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

railties

3 participants

@igorkasyanchuk @fatkodima @skipkayhil