Skip to content

fix duplicate import of global var path in symlink file #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2023
Merged

fix duplicate import of global var path in symlink file #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/cover/internal/tool/cover.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ package tool

import (
"bytes"
"strings"

// "flag"
"fmt"
"go/ast"
Expand Down Expand Up @@ -342,6 +344,8 @@ func Annotate(name string, mode string, varVar string, globalCoverVarImportPath

if bytes.Equal(content, newContent) {
log.Info("no cover var injected for: ", name)
} else if strings.Contains(string(file.content), globalCoverVarImportPath) {
log.Info("global cover var already imported for: ", name)
} else {
// reback to the beginning
file.astFile, _ = parser.ParseFile(fset, name, content, parser.ParseComments)
Expand Down