Fix concurrent map iteration & write issue #329
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The issue was introduced in
func (l *fileStore) Remove(addr string) errorhttps://github.com/qiniu/goc/blob/master/pkg/cover/store.go#L107
when we set the memory server list back to file.
the list
l.memoryStore.GetAll() -> servicespassed intofunc (l *fileStore) Set(services map[string][]string) errorin L175 we sign the
servicesdirectly tol.memoryStore.servicesMap, without copying it.while in L186 we are still using this map to do the iteration without lock. (by right should use
memoryStore.mu.The issue will happen when there is another goroutine tries to remove the server from memoryStore. Map will clash.