Skip to content

Conversation

@CarlJi
Copy link
Collaborator

@CarlJi CarlJi commented Sep 5, 2022

fix #303

@qiniu-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CarlJi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #305 (683b20d) into master (6795ec7) will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #305 +/- ## ========================================== - Coverage 70.85% 70.66% -0.20%  ========================================== Files 34 34 Lines 2035 2035 ========================================== - Hits 1442 1438 -4  - Misses 480 483 +3  - Partials 113 114 +1 
Flag Coverage Δ
e2e-1.16.x ?
e2e-1.17.x ?
e2e-1.18.x ?
e2e-1.19.x ?
unittest-1.16.x 70.66% <ø> (-0.10%) ⬇️
unittest-1.17.x 70.66% <ø> (ø)
unittest-1.18.x 70.66% <ø> (-0.10%) ⬇️
unittest-1.19.x 70.66% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cover/instrument.go 20.83% <ø> (ø)
pkg/build/gomodules.go 89.18% <0.00%> (-5.41%) ⬇️
pkg/build/legacy.go 95.12% <0.00%> (-4.88%) ⬇️
@CarlJi CarlJi merged commit e4a6b38 into qiniu:master Sep 5, 2022
@CarlJi CarlJi deleted the log_revise branch September 5, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants