Allow attributes to be set via constructors #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This is great, thanks! 🍰 ✨ 🍰 |
Lukasa added a commit that referenced this pull request Sep 19, 2015
Allow attributes to be set via constructors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR supersedes #7 and allows setting all frame attributes via constructors. The only unusual thing in this PR might be that mixin arguments (and
flags) are provided as keyword arguments only. This has been done as the combination of mixins and positional arguments tends to be quite confusing.An alternative would be to repeat all arguments in each constructor, but I found this to be quite verbose.