Avoid task WDT invoked when URLStreamBufferedESP32 stream is temporarily stopped #2238
+7 −3
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When
URLStreamBufferedis used on ESP32 and the stream is temporarily stopped for several seconds, the task watchdog timer is invoked within theBufferedTaskStreamtask and ESP32 is reset, because the task is blocked whilereadBytes()from the stream.( This can be seen in the stream like jazz cafe, that has a few seconds gaps between tunes. )
This patch avoids the WDT by calling
dalay()if there is no readable bytes.In addition, if the stream is stopped, the sink like
AudioPlayer::copy()from theURLStreamBufferedis also blocked and makes it difficult to handle timeouts (e.g. switching to the next source). This changes the default timeout ofSynchronizedNBufferRTOSTto 1 second, so that the copier can return with0copied byte after the timeout.