Skip to content

Master add conditions to status of custom resource. #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 15, 2020
Merged

Master add conditions to status of custom resource. #80

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c59c47d
Added conditions to AppWrapper CRD.
dmatch01 Nov 12, 2020
9de4206
Reduced repeating conditions and coded reason for condition instead o…
dmatch01 Nov 13, 2020
6174473
Debugging statements.
dmatch01 Nov 13, 2020
d9450fa
Debugging statements.
dmatch01 Nov 13, 2020
1bd9095
Debugging statements.
dmatch01 Nov 13, 2020
0380c5c
Debugging statements.
dmatch01 Nov 13, 2020
a474ab5
Added additional debugging.
dmatch01 Nov 14, 2020
2d54f9b
Added additional debugging.
dmatch01 Nov 14, 2020
e5f3f76
Added additional debugging.
dmatch01 Nov 14, 2020
be348f0
Added additional debugging.
dmatch01 Nov 14, 2020
dc865d6
Added additional debugging.
dmatch01 Nov 14, 2020
4365053
Added additional debugging.
dmatch01 Nov 15, 2020
810e06e
Removedadditional debugging.
dmatch01 Nov 15, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added additional debugging. 
Signed-off-by: Diana Arroyo <darroyo@us.ibm.com>
  • Loading branch information
@dmatch01
dmatch01 committed Nov 14, 2020
commit be348f06c598a11deb516223a35e5fca4ed88666
18 changes: 10 additions & 8 deletions pkg/apis/controller/v1alpha1/appwrapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,14 +220,16 @@ const (
type AppWrapperConditionType string

const (
AppWrapperCondInit AppWrapperConditionType = "Init"
AppWrapperCondQueueing AppWrapperConditionType = "Queueing"
AppWrapperCondHeadOfLine AppWrapperConditionType = "HeadOfLine"
AppWrapperCondBackoff AppWrapperConditionType = "Backoff"
AppWrapperCondDispatched AppWrapperConditionType = "Dispatched"
AppWrapperCondRunning AppWrapperConditionType = "Running"
AppWrapperCondDeleted AppWrapperConditionType = "Deleted"
AppWrapperCondFailed AppWrapperConditionType = "Failed"
AppWrapperCondInit AppWrapperConditionType = "Init"
AppWrapperCondQueueing AppWrapperConditionType = "Queueing"
AppWrapperCondHeadOfLine AppWrapperConditionType = "HeadOfLine"
AppWrapperCondBackoff AppWrapperConditionType = "Backoff"
AppWrapperCondDispatched AppWrapperConditionType = "Dispatched"
AppWrapperCondRunning AppWrapperConditionType = "Running"
AppWrapperCondPreemptCandidate AppWrapperConditionType = "PreemptCandidate"
AppWrapperCondPreempted AppWrapperConditionType = "Preempted"
AppWrapperCondDeleted AppWrapperConditionType = "Deleted"
AppWrapperCondFailed AppWrapperConditionType = "Failed"
)

// DeploymentCondition describes the state of a deployment at a certain point.
Expand Down
8 changes: 8 additions & 0 deletions pkg/controller/queuejob/queuejob_controller_ex.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,14 @@ func (qjm *XController) PreemptQueueJobs() {
continue
}
newjob.Status.CanRun = false
if (q.Name == "aw-generic-deployment-2-030") {
glog.V(3).Infof("[PreemptQueueJobs] %s PreemptQueue &qj=%p Version=%s Status=%+v aw=%v", q.Name, q, q.ResourceVersion, q.Status, q)
glog.V(3).Infof("[PreemptQueueJobs] %s from cache &qj=%p Version=%s Status=%+v aw=%v", newjob.Name, newjob, newjob.ResourceVersion, newjob.Status, newjob)
}
message := fmt.Sprintf("Insufficient number of Running pods, minimum=%s, running=%s", string(newjob.Spec.SchedSpec.MinAvailable), string(newjob.Status.Running))
cond := GenerateAppWrapperCondition(arbv1.AppWrapperCondPreemptCandidate, v1.ConditionTrue, "MinPodsNotRunning", message)
newjob.Status.Conditions = append(newjob.Status.Conditions, cond)

if _, err := qjm.arbclients.ArbV1().AppWrappers(q.Namespace).Update(newjob); err != nil {
glog.Errorf("Failed to update status of AppWrapper %v/%v: %v",
q.Namespace, q.Name, err)
Expand Down