AppWrapper requeueing fix when the job is completed #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…was happening because at the end of the job, when all the pods are completed, MCAD would see no 'running' pods so it would think the job needs to be re-queued. Added also a fix to prevent MCAD from deleting AppWrappers after the pods or the application is done. Signed-off-by: Pedro D. Bello-Maldonado <metalcycling@gmail.com>
asm582 requested changes Dec 7, 2022
| | ||
| if aw.Status.Running < int32(aw.Spec.SchedSpec.MinAvailable) { | ||
| if (aw.Status.Running + aw.Status.Succeeded) < int32(aw.Spec.SchedSpec.MinAvailable) { | ||
| message = fmt.Sprintf("Insufficient number of Running pods, minimum=%d, running=%v.", aw.Spec.SchedSpec.MinAvailable, aw.Status.Running) |
Member
There was a problem hiding this comment.
Should we change logger message, it should reflect Running and Completed
…leted pods Signed-off-by: Pedro D. Bello-Maldonado <metalcycling@gmail.com>
Member
| Thanks @metalcycling , LGTM! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pedro D. Bello-Maldonado metalcycling@gmail.com