Skip to content

Conversation

@harshved
Copy link
Contributor

@harshved harshved commented Jul 30, 2021

Related Issue

  • Info about the related issue

  • LGM-SOC'21 Participant

  • DevIncept Participant

  • Contributor

Closes: #123

Describe the changes you've made

Added the Code which detect Lane from the image and gives the output.
Note: If you use your image just set the area of interest as per the image to get better and perfect output.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how have you verified the changes made

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Detected Lane

@welcome
Copy link

welcome bot commented Jul 30, 2021

Hello there! 👋 Welcome to the project! 💖
Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄

Feel free to get in touch with me through social media handles. Hope to see you there!😄

@prathimacode-hub
Copy link
Owner

Follow the PR template, edit it and add the project details to check onto your PR. @harshved

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes to be done in project structure:
Images and output screenshots should be in "Images" folder
Readme file should be as README.md and it needs more elaboration. Lacks details on the project
The project file should be as "lane_detector.py"
Also a "requirements.txt" file which lists out all the libraries used in this project.
Kindly do these changes. @harshved

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done:
All images and output screenshots should be in "Images" folder
Also add compilation steps and purpose of the project in README.md

Kindly do these changes. @harshved

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. Impressive and good take up. Welcome to repo officially. Yay. 👌👏@harshved

@prathimacode-hub prathimacode-hub added DCP21 This issue will be considered for DCP 21 To Do Update Pending 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. labels Aug 3, 2021
@prathimacode-hub prathimacode-hub merged commit d5fadc2 into prathimacode-hub:main Aug 3, 2021
@welcome
Copy link

welcome bot commented Aug 3, 2021

Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️

@prathimacode-hub prathimacode-hub removed the To Do Update Pending label Aug 3, 2021
@prathimacode-hub
Copy link
Owner

Hey, I could see you haven't filled up the form yet with your PR link. Kindly do it to let your contribution count. Form is available in project channel of the slack. Do fill it up and let me know. I need to add your score. Do it by tomorrow evening as I have to send up the scores to DCP team. @harshved

@harshved
Copy link
Contributor Author

harshved commented Aug 8, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DCP21 This issue will be considered for DCP 21 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21.

2 participants