Skip to content

Conversation

@kumarjeetray
Copy link
Contributor

@kumarjeetray kumarjeetray commented Jun 26, 2021

Related Issue

  • Info about the related issue

  • LGM-SOC'21 Participant

  • Contributor

Closes: #450

Describe the changes you've made

Give a clear description what modifications you have made

I have made the file

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I have run and tested the code

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.
Copy link
Collaborator

@Debashish-hub Debashish-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a requirements.txt file
Rename your folder to "Stone Paper Pencil Rubber & Scissor"
Instead of the image source as the link use image path i.e. "Images/imageName.jpg" as you had done earlier.
Do comment your code wherever necessary
Do these changes @kumarjeetray

@Debashish-hub Debashish-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 27, 2021
@kumarjeetray kumarjeetray changed the title Stone_Paper_Pencil_Rubber_Scissor Stone Paper Pencil Rubber & Scissor Jun 27, 2021
Copy link
Contributor Author

@kumarjeetray kumarjeetray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done Changes. The code already has comments wherever required. There is an error while changing the folder name from my computer. Can't do that. Rest is done

…er_pencil_rubber_scissor.py to BasicPythonScripts/Stone Paper Pencil Rubber & Scissor/Stone_paper_pencil_rubber_scissor.py
…aper_pencil_rubber_scissor.py to BasicPythonScripts/Stone_paper_pencil_rubber_scissor/Stone_paper_pencil_rubber_scissor.py
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done:
The folder name should be titled as "Stone Paper Pencil Rubber Scissor"
The requirements file should be titled as "requirements.txt". Add libraries imported in this file.
The project file should be titled as "stone_paper_pencil_rubber_Scissor.py"
Add appropriate comments in code wherever needed.

Kindly do the needful changes. @kumarjeetray

… to BasicPythonScripts/Stone Paper Pencil Rubber Scissor/README.md
…er_pencil_rubber_scissor.py to BasicPythonScripts/Stone Paper Pencil Rubber Scissor/Stone_paper_pencil_rubber_scissor.py
…nts.txt to BasicPythonScripts/Stone Paper Pencil Rubber Scissor/Images/Requirements.txt
…quirements.txt to BasicPythonScripts/Stone Paper Pencil Rubber Scissor/Requirements.txt
@kumarjeetray
Copy link
Contributor Author

Changes to be done:
The folder name should be titled as "Stone Paper Pencil Rubber Scissor"
The requirements file should be titled as "requirements.txt". Add libraries imported in this file.
The project file should be titled as "stone_paper_pencil_rubber_Scissor.py"
Add appropriate comments in code wherever needed.

Kindly do the needful changes. @kumarjeetray
Please check now

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great going. Congo. Your PR is approved. Amazing work. Good to see your progress. Keep growing. ✔👌@kumarjeetray

@prathimacode-hub prathimacode-hub added To Do Update Pending 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. labels Jun 27, 2021
@prathimacode-hub prathimacode-hub merged commit aecdc63 into prathimacode-hub:main Jun 27, 2021
@prathimacode-hub prathimacode-hub removed the To Do Update Pending label Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. LGMSOC21 This issue will be considered for LGM-SOC 21

3 participants