-
- Notifications
You must be signed in to change notification settings - Fork 263
Stone Paper Pencil Rubber & Scissor #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r/Images/README.md to BasicPythonScripts/Stone_paper_pencil_rubber_scissor/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a requirements.txt file
Rename your folder to "Stone Paper Pencil Rubber & Scissor"
Instead of the image source as the link use image path i.e. "Images/imageName.jpg" as you had done earlier.
Do comment your code wherever necessary
Do these changes @kumarjeetray
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done Changes. The code already has comments wherever required. There is an error while changing the folder name from my computer. Can't do that. Rest is done
…er_pencil_rubber_scissor.py to BasicPythonScripts/Stone Paper Pencil Rubber & Scissor/Stone_paper_pencil_rubber_scissor.py
…aper_pencil_rubber_scissor.py to BasicPythonScripts/Stone_paper_pencil_rubber_scissor/Stone_paper_pencil_rubber_scissor.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to be done:
The folder name should be titled as "Stone Paper Pencil Rubber Scissor"
The requirements file should be titled as "requirements.txt". Add libraries imported in this file.
The project file should be titled as "stone_paper_pencil_rubber_Scissor.py"
Add appropriate comments in code wherever needed.
Kindly do the needful changes. @kumarjeetray
… to BasicPythonScripts/Stone Paper Pencil Rubber Scissor/README.md
…er_pencil_rubber_scissor.py to BasicPythonScripts/Stone Paper Pencil Rubber Scissor/Stone_paper_pencil_rubber_scissor.py
…nts.txt to BasicPythonScripts/Stone Paper Pencil Rubber Scissor/Images/Requirements.txt
…quirements.txt to BasicPythonScripts/Stone Paper Pencil Rubber Scissor/Requirements.txt
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great going. Congo. Your PR is approved. Amazing work. Good to see your progress. Keep growing. ✔👌@kumarjeetray
Related Issue
Info about the related issue
LGM-SOC'21 Participant
Contributor
Closes: #450
Describe the changes you've made
Give a clear description what modifications you have made
I have made the file
What sort of change have you made:
How Has This Been Tested?
I have run and tested the code
Checklist: