Skip to content

Conversation

@akash-rajak
Copy link
Contributor

Related Issue

  • Info about the related issue

  • LGM-SOC'21 Participant

  • Contributor

fixes : #467
Closes: #467

Describe the changes you've made

  • A "World Bank GDP Ranking" is an application created in python with tkinter gui.
  • In this application, user can find the GDP Ranking of any country entring just country code.
  • The information can be like Ranking , Economy, and how many US Dollars.
  • for the data, used the gdp.csv data, and read using pandas library.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

yes , below i have provided the a screenshots and video link for showing how it works. and video of its working also.

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
Original Screenshot Updated Screenshot

Below are the screenshots showing how application works,

1

2

3

4

5

6

7

@prathimacode-hub prathimacode-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 24, 2021
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done:

  • Add purpose and compilation steps in your README.md file
  • The project folder should be titled as "World Bank GDP Ranking"

Kindly do these changes. @akash435

@akash-rajak
Copy link
Contributor Author

ok mam

@akash-rajak
Copy link
Contributor Author

@prathimacode-hub , Added purpose and compilation steps in readme and changed the folder name, please check it

@prathimacode-hub
Copy link
Owner

@prathimacode-hub , Added purpose and compilation steps in readme and changed the folder name, please check it

I don't find the changes in the foldername. Can you recheck it? Also the old files are still up there. @akash435

@akash-rajak
Copy link
Contributor Author

means I have to add new folder by deleting old folder , is this?

@prathimacode-hub
Copy link
Owner

means I have to add new folder by deleting old folder , is this?

Yes. Add the project files in new folder in your forked repository. Delete old repository and push the changes. @akash435

@akash-rajak
Copy link
Contributor Author

ok mam

@prathimacode-hub prathimacode-hub added wontfix This will not be worked on and removed LGMSOC21 This issue will be considered for LGM-SOC 21 labels Jun 25, 2021
@prathimacode-hub prathimacode-hub added invalid This doesn't seem right and removed wontfix This will not be worked on labels Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

2 participants