rps.py added in PyGamesScrips [issue43] #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
prathimacode-hub requested changes Jun 6, 2021
There was a problem hiding this comment.
Great to see you contribute again to this repository. Need few changes before I merge.
- File name of the script should be as "file_name.py" and Folder name as "Rock Paper Scissors".
- README should be elaborative for readers to understand. Add a small introduction of what the project is, the workflow of the project, libraries needed, how project can be executed.
- Screenshot inclusion of the project is must in README file.
Once these things are corrected, I would be happy to merge. ✔ @MuditCh57
| Thank You mam for your feedback. I will correct my mistake 👍. |
Images were not showing. Fix this error.
| Hope I've corrected my mistake. If something still wrong please correct me. |
prathimacode-hub approved these changes Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixed issue number #43
Closes : #43