Skip to content

Move the Box #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 14, 2021
Merged

Move the Box #219

merged 4 commits into from
Jun 14, 2021

Conversation

manognyaa
Copy link
Contributor

Related Issue

Small kids don't know what to play. Keeping in mind that, I have created this move the box game where kids can play easily.

  • Info about the related issue

  • LGM-SOC'21 Participant

  • Contributor

Closes: #90

Describe the changes you've made

  • I have added readme file.
  • I have updated the code with required comments.
  • I have imported pygame.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

You can download the code into your local computer, and run it. It work successfully.

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
before moving the box anywhere
before moving anywhere
moving the box to down
after moving to down

moving the box to left
after moving to left

moving the box to right
after moving to right

moving the box to top
after moving to top

| Updated Screenshot |

@prathimacode-hub , kindly review it mam, if there any changes, please guide me mam
prathimacode-hub
prathimacode-hub requested changes Jun 14, 2021
View reviewed changes
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should be as move_the_box.py
Other than that, all perfect. You had shown lot of improvement. @manognyaa
@manognyaa
Copy link
Contributor Author

File name should be as move_the_box.py
Other than that, all perfect. You had shown lot of improvement. @manognyaa

Thank you @prathimacode-hub mam, I have renamed the file.
Please verify and guide me if any changes required.
@prathimacode-hub prathimacode-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 14, 2021
prathimacode-hub
prathimacode-hub approved these changes Jun 14, 2021
View reviewed changes
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is approved. I appreciate your worthy efforts. Proud of you. ✨✨✨@manognyaa
@prathimacode-hub prathimacode-hub added the 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. label Jun 14, 2021
@prathimacode-hub prathimacode-hub merged commit f315cb0 into prathimacode-hub:main Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. LGMSOC21 This issue will be considered for LGM-SOC 21

2 participants

@manognyaa @prathimacode-hub