Skip to content

Conversation

Bhuvanharsha16
Copy link
Contributor

@Bhuvanharsha16 Bhuvanharsha16 commented Jun 14, 2021

Title: Real-time currency converter

Describe the changes you've made

This is a python script that can perform multiple tasks on currencies like exchange rate, currency conversion, get currency names and symbols

Type of change

What sort of change have you made:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This code has been tried on my local machine.

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly where ever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots:

image

@welcome
Copy link

welcome bot commented Jun 14, 2021

Hello there! 👋 Welcome to the project! 💖
Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄

Feel free to get in touch with me through social media handles. Hope to see you there!😄

@prathimacode-hub prathimacode-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 14, 2021
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done:

  • All images and screenshots should be in "Images" folder
  • Add the images links in README file that are in the file path of "Images" folder
  • Your project folder should be as "Real-Time Currency Converter"
  • Add appropriate comments wherever necessary in your project file to get good
    understanding of the program.
  • Add the libraries imported in "requirements.txt" file.
  • Remove all the '.idea' related files from the project. Those are unnecessary things.

Kindly do the needful changes. @Bhuvanharsha16

Here are some snaps of my code in action
@prathimacode-hub prathimacode-hub added invalid This doesn't seem right and removed LGMSOC21 This issue will be considered for LGM-SOC 21 labels Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

2 participants