Skip to content

Conversation

@Kushal997-das
Copy link
Contributor

@Kushal997-das Kushal997-das commented May 29, 2021

Closes : #20

shiv (2)

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see your initiation to contribute. Go through the contributing guidelines 👍🙂
I will make things simple for you by stating the changes needed.

  • Kindly add this project under "GUIScripts" repository.
  • In this folder, add your project with repository name as "FaceSketching". Also, add Face_Sketching.py and README.md as file name.
  • Add Jpg file and GIF file in separate "Images" folder and direct them to the README.md file.

Scripts are perfect. Do these required changes and its done. @Kushal997-das

@Kushal997-das
Copy link
Contributor Author

Good to see your initiation to contribute. Go through the contributing guidelines 👍🙂
I will make things simple for you by stating the changes needed.

  • Kindly add this project under "GUIScripts" repository.
  • In this folder, add your project with repository name as "FaceSketching". Also, add Face_Sketching.py and README.md as file name.
  • Add Jpg file and GIF file in separate "Images" folder and direct them to the README.md file.

Scripts are perfect. Do these required changes and its done. @Kushal997-das

Please add these points in contributing.md so that anyone can't fall into trouble after sending PR .
Moreover i can put this file under GUI but i can't change the project name because this is not face kind of things .

@prathimacode-hub
Copy link
Owner

Ok. Sure. The points I have mentioned are in template. Anyways thanks for your suggestions. I will modify the changes needed in a single file. @Kushal997-das

@Kushal997-das
Copy link
Contributor Author

Ok. Sure. The points I have mentioned are in template. Anyways thanks for your suggestions. I will modify the changes needed in a single file. @Kushal997-das

So you will do this or i will do from my end ?

@prathimacode-hub
Copy link
Owner

I had done the changes needed. I have merged both the template and contributing guidelines into one. @Kushal997-das

@Kushal997-das
Copy link
Contributor Author

I had done the changes needed. I have merged both the template and contributing guidelines into one. @Kushal997-das

Now check

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and also for suggesting the changes needed. It was a good addon to this repository. 👍@Kushal997-das

@prathimacode-hub prathimacode-hub merged commit 836ac3e into prathimacode-hub:main May 29, 2021
@Kushal997-das
Copy link
Contributor Author

Thank you for your contribution and also for suggesting the changes needed. It was a good addon to this repository. 👍@Kushal997-das

Most welcome dear check your mail i send you invitation you can join my organisation thank you :)

@prathimacode-hub
Copy link
Owner

I had already joined. Thanks for the invitation.🙂@Kushal997-das

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants