Skip to content

Conversation

codeaholic-shub
Copy link
Contributor

@codeaholic-shub codeaholic-shub commented Jun 14, 2021

Related Issue

  • Made Minesweeper Game using 2D Implementation of Python

  • LGM-SOC'21 Participant

  • Contributor

Closes: #193

Describe the changes you've made

I have made a Minesweeper Game using 2D Python Implementation

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how have you verified the changes made

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

First Projedct – minesweeper py PyCharm 13-06-2021 20_26_34
First Projedct – minesweeper py PyCharm 13-06-2021 20_26_45

Hello @prathimacode-hub mam,
Kindly Review my PR !

@prathimacode-hub prathimacode-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 14, 2021
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done:

Add imported libraries in the "requirements.txt" file
Elaborate the README.md file. Give short intro about the game. Aim. Purpose, workflow of the project, compilation steps.
Add the images and screenshots in "Images" folder
Provide the image links file path that's added up in "Images" folder. Not user-images.

Kindly do the needful changes. @codeaholic-shub

@codeaholic-shub
Copy link
Contributor Author

Changes to be done:

Add imported libraries in the "requirements.txt" file
Elaborate the README.md file. Give short intro about the game. Aim. Purpose, workflow of the project, compilation steps.
Add the images and screenshots in "Images" folder
Provide the image links file path that's added up in "Images" folder. Not user-images.

Kindly do the needful changes. @codeaholic-shub

Hello @prathimacode-hub mam,
As per yours instructions and guidelines ,I have made changes,
Kindly Review my PR !

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add imported libraries in the "requirements.txt" file
Provide the image links file path that's added up in "Images" folder. Not user-images it should show the file path of the image present in "Images" folder.

These aren't done I guess. Correct me, if i am wrong. @codeaholic-shub

@codeaholic-shub
Copy link
Contributor Author

codeaholic-shub commented Jun 14, 2021

Add imported libraries in the "requirements.txt" file
Provide the image links file path that's added up in "Images" folder. Not user-images it should show the file path of the image present in "Images" folder.

These aren't done I guess. Correct me, if i am wrong. @codeaholic-shub

@prathimacode-hub Mam,
As per yours instructions, I have made changes,
Kindly Review my PR mam !

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is approved and merged. Good job. 👏✨@codeaholic-shub

@prathimacode-hub prathimacode-hub added the 🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21 & DCP21. label Jun 14, 2021
@prathimacode-hub prathimacode-hub merged commit 00efbbf into prathimacode-hub:main Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21 & DCP21. LGMSOC21 This issue will be considered for LGM-SOC 21

2 participants