Skip to content

Conversation

vaikunth-coder27
Copy link
Contributor

Related Issue

  • WEATHER REPORT GUI SCRIPT

  • LGM-SOC'21 Participant

  • Contributor

Closes: #83

Describe the changes you've made

  • Added to code to display the weather report
  • Added README file
  • Added requirements.txt file
  • Added output images under images folder

Types of changes

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The program has been tested for various test cases and the required output is obtained successfully.

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

output1
output2

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done

  • Add all the images in "Images" folder.
  • Add appropriate comments in project files to get good understanding of the program.
  • Change the image links of output screenshots which is in format of user-images added in README.md file to the images link that's added up in this current repository.

Kindly do the needful changes. @vaikunth-coder27

@prathimacode-hub prathimacode-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 14, 2021
@vaikunth-coder27
Copy link
Contributor Author

Ma'am, I have made the necessary changes as mentioned.

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats. Your PR is approved and merged. You can take up an another issue to work on. Good going. 👍👌@vaikunth-coder27

@prathimacode-hub prathimacode-hub added the 🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21 & DCP21. label Jun 14, 2021
@prathimacode-hub prathimacode-hub merged commit 37a305f into prathimacode-hub:main Jun 14, 2021
@welcome
Copy link

welcome bot commented Jun 14, 2021

Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21 & DCP21. LGMSOC21 This issue will be considered for LGM-SOC 21

2 participants