Skip to content

Conversation

@pankaj892
Copy link
Contributor

@pankaj892 pankaj892 commented Jun 13, 2021

Related Issue

  • Info about the related issue

  • LGM-SOC'21 Participant

  • Contributor

Closes: #177

Describe the changes you've made

Added Random Email generator which asks user for input for total number of emails and creates email addresses based on the number specified by the user

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how have you verified the changes made

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Random Email

Signed-off-by: Pankaj Biradar <pankaj28988@gmail.com>
Signed-off-by: Pankaj Biradar <pankaj28988@gmail.com>
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done:

  • Elaborate your README.md file more briefly. It needs more description.
  • Add images and screenshots in "Images" folder
  • Add your output screenshot in README.md file using the image links that's added up in "Images" folder
  • Add libraries imported for this project in "requirements.txt" file.

Kindly do the needful changes. @pankaj892

@prathimacode-hub prathimacode-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 14, 2021
Signed-off-by: Pankaj Biradar <pankaj28988@gmail.com>
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no changes. Only this needed is this project should go into "AutomationScripts" @pankaj892

Signed-off-by: Pankaj Biradar <pankaj28988@gmail.com>
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is approved. You can take up another issue to work on. This PR will be merged soon. @pankaj892

@Debashish-hub Debashish-hub added the 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. label Jun 14, 2021
@Debashish-hub Debashish-hub merged commit b28dbab into prathimacode-hub:main Jun 14, 2021
@pankaj892 pankaj892 deleted the random-email branch June 28, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. LGMSOC21 This issue will be considered for LGM-SOC 21

3 participants