Skip to content

COWIN API SCRIPT #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 14, 2021
Merged

COWIN API SCRIPT #182

merged 5 commits into from
Jun 14, 2021

Conversation

Bhuvanaa28
Copy link
Contributor

Related Issue

  • COWIN API Script

  • LGM-SOC'21 Participant

Closes: #140

Describe the changes you've made

  • Added the code to obtain details of vaccination sessions
  • Added README file
  • Added screenshots in Images folder

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I executed the code for different test cases and obtained the expected output

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

img4
prathimacode-hub
prathimacode-hub requested changes Jun 13, 2021
View reviewed changes
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done :

  • Add libraries imported in "requirements.txt" file.
  • Elaborate the README.md file
  • Add appropriate comments in your project file wherever needed to get good understanding of it.

Kindly do the needful changes. @Bhuvanaa28
@prathimacode-hub prathimacode-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 13, 2021
ghost
ghost suggested changes Jun 13, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In python script, if you can add more comments will help to under code better.
APIScripts/COWIN API/README.md Outdated
@@ -0,0 +1,43 @@
# COWIN API

CoWIN is a cloud-based IT solution for planning, implementation, monitoring, and evaluation of Covid-19 vaccination in India.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct the CoWIN to COWIN.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prathimacode-hub Please review about more comments or code description.
@Bhuvanaa28
Copy link
Contributor Author

Changes to be done :

  • Add libraries imported in "requirements.txt" file.
  • Elaborate the README.md file
  • Add appropriate comments in your project file wherever needed to get good understanding of it.

Kindly do the needful changes. @Bhuvanaa28

I have done the necessary changes Mam
ghost
ghost approved these changes Jun 14, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's all working! Great.
@prathimacode-hub
Copy link
Owner

@thegautamkumarjaiswal You're not allowed to review the PR's, as you being a LGMSOC participant. Kindly note this.
prathimacode-hub
prathimacode-hub approved these changes Jun 14, 2021
View reviewed changes
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is approved and merged successfully. You had done an amazing work. Keep rising. 🙌✔@Bhuvanaa28
@prathimacode-hub prathimacode-hub added the 🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21 & DCP21. label Jun 14, 2021
@prathimacode-hub prathimacode-hub merged commit ad5631f into prathimacode-hub:main Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21 & DCP21. LGMSOC21 This issue will be considered for LGM-SOC 21

2 participants

@Bhuvanaa28 @prathimacode-hub