Skip to content

Conversation

@hr1shu
Copy link
Contributor

@hr1shu hr1shu commented Jun 12, 2021

Closes : #101

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done:

  • PR commit message isn't in right template.
  • PR title doesn't show the project title.
  • You hadn't added your issue number in commit message
  • Follow the project structure and guidelines mentioned.
  • The project file name should be "password_checker.py"
  • Your project repository should be as "Password Checker"
  • Elaborate your README. md file.
  • Add the output screenshot to your README.md file.
  • In your project file, add comments wherever necessary
  • All images and screenshots should be in "Images" folder.

Always read the CONTRIBUTING GUIDELINES and README of the project before you raise a PR.
@hr1shu

@prathimacode-hub prathimacode-hub added the LGMSOC21 This issue will be considered for LGM-SOC 21 label Jun 12, 2021
@hr1shu
Copy link
Contributor Author

hr1shu commented Jun 12, 2021

On it!!!

@hr1shu hr1shu changed the title Uploaded the checker script Password Checker Jun 12, 2021
@hr1shu
Copy link
Contributor Author

hr1shu commented Jun 12, 2021

Title: Password Checker
Info about the related issue:
You have to enter your password keyword to check how many times your password has been compromised.

->LGM-SOC'21 Participant

Closes: #101

Type of change
What sort of change have you made:

-> New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Code style update (formatting, local variables)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:
-> My code follows the guidelines of this project.
->I have performed a self-review of my own code.
->I have commented my code, particularly where ever it was hard to understand.
->I have made corresponding changes to the documentation.
->My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
Any dependent changes have been merged and published in downstream modules.
Screenshots

Output

@hr1shu
Copy link
Contributor Author

hr1shu commented Jun 12, 2021

The image file is not appearing in readme file, plz help!!

@prathimacode-hub
Copy link
Owner

The image file is not appearing in readme file, plz help

Image file is in which format?

@hr1shu
Copy link
Contributor Author

hr1shu commented Jun 12, 2021

The image file is not appearing in readme file, plz help

Image file is in which format?

Png

@Debashish-hub
Copy link
Collaborator

Debashish-hub commented Jun 12, 2021

The image file is not appearing in readme file, plz help!!

Try this - img src="Images/Output.png"

@hr1shu
Copy link
Contributor Author

hr1shu commented Jun 12, 2021

The image file is not appearing in readme file, plz help!!

Try this - img src="Images/Output.png"

This didn't worked, but I tried something different and it works now.

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey in program file, add comments wherever needed to know the right workflow as it's not been added in README.

Do these changes. @hr1shu

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats, your PR is approved and will be merged soon. You can take another issue to work upon. 👏@hr1shu

@prathimacode-hub prathimacode-hub added the 🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. label Jun 12, 2021
@prathimacode-hub prathimacode-hub merged commit 2b7e32e into prathimacode-hub:main Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🟨 Level2 This issue will be considered as level 2 issue for LGM-SOC 21 & DCP21. LGMSOC21 This issue will be considered for LGM-SOC 21

3 participants