-
- Notifications
You must be signed in to change notification settings - Fork 263
Password Checker #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password Checker #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to be done:
- PR commit message isn't in right template.
- PR title doesn't show the project title.
- You hadn't added your issue number in commit message
- Follow the project structure and guidelines mentioned.
- The project file name should be "password_checker.py"
- Your project repository should be as "Password Checker"
- Elaborate your README. md file.
- Add the output screenshot to your README.md file.
- In your project file, add comments wherever necessary
- All images and screenshots should be in "Images" folder.
Always read the CONTRIBUTING GUIDELINES and README of the project before you raise a PR.
@hr1shu
| On it!!! |
| Title: Password Checker ->LGM-SOC'21 Participant Closes: #101 Type of change -> New feature (non-breaking change which adds functionality) Checklist: |
| The image file is not appearing in readme file, plz help!! |
Image file is in which format? |
Png |
Try this - img src="Images/Output.png" |
This didn't worked, but I tried something different and it works now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey in program file, add comments wherever needed to know the right workflow as it's not been added in README.
Do these changes. @hr1shu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats, your PR is approved and will be merged soon. You can take another issue to work upon. 👏@hr1shu

Closes : #101