Skip to content

Conversation

photon149
Copy link
Contributor

Related Issue

  • Info about the related issue

  • Hacktoberfest2021 Participant

  • Contributor

Closes: #1072 issue number that will be closed through this PR

Describe the add-ons or changes you've made

We implemented Faker API , with a detailed explanation of its working , and with a lot of examples.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manually run and tested

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.
@welcome
Copy link

welcome bot commented Oct 31, 2021

Hello there! 👋 Welcome to the project! 💖
Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄

Feel free to get in touch with me through social media handles. Hope to see you there!😄

@photon149
Copy link
Contributor Author

@prathimacode-hub please check and review the same.

@prathimacode-hub prathimacode-hub added the HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 label Oct 31, 2021
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add output screenshots in "Images" folder in this project and add the links of the images present in this repo to your README file instead of user-images content. @photon149

@photon149
Copy link
Contributor Author

Done with the suggested changes @prathimacode-hub .

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. Great going. Keep it up. 👏👌@photon149

@prathimacode-hub prathimacode-hub added the HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest label Oct 31, 2021
@prathimacode-hub prathimacode-hub merged commit dca1bb0 into prathimacode-hub:main Oct 31, 2021
@welcome
Copy link

welcome bot commented Oct 31, 2021

Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest

2 participants