Skip to content

Conversation

Khushi-sharma07
Copy link
Contributor

@Khushi-sharma07 Khushi-sharma07 commented Oct 30, 2021

Related Issue
A Python script to generate the calculator which work on voice commands.

  • Hacktoberfest2021 Participant
  • Contributor

Closes: #927

Describe the changes you've made
Added required files as per the requirement of Voice Calculator generation.

Type of change
What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?
Tested the script on my local machine for different test cases.

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots:

Screenshot (121)

@Khushi-sharma07
Copy link
Contributor Author

Mam please review my code.😊

@Khushi-sharma07
Copy link
Contributor Author

Mam please review the p.r 🙏 @prathimacode-hub

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README can elaborated briefly. @Khushi-sharma07

@prathimacode-hub prathimacode-hub added the HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 label Oct 30, 2021
Copy link
Contributor Author

@Khushi-sharma07 Khushi-sharma07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mam I had tried to add more details in the README.md file, I am not getting anymore ideas to add in this as it is a simple GUI script.

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. 👏👌@Khushi-sharma07

@prathimacode-hub prathimacode-hub added the HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest label Oct 30, 2021
@prathimacode-hub prathimacode-hub merged commit 2b8da68 into prathimacode-hub:main Oct 30, 2021
@Khushi-sharma07
Copy link
Contributor Author

Thank you mam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest

2 participants