Skip to content

Conversation

hr1shu
Copy link
Contributor

@hr1shu hr1shu commented Oct 26, 2021

Related Issue

  • Info about the related issue

  • Hacktoberfest2021 Participant

Closes: #1061 number that will be closed through this PR

Describe the changes you've made

Uploaded required files for my issue

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how have you verified the changes made

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.
@hr1shu
Copy link
Contributor Author

hr1shu commented Oct 26, 2021

Plz review this and let me know if any changes are required @prathimacode-hub

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. 🙌👌@hr1shu

@prathimacode-hub prathimacode-hub added HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest labels Oct 28, 2021
@prathimacode-hub prathimacode-hub merged commit 545e60f into prathimacode-hub:main Oct 28, 2021
@hr1shu
Copy link
Contributor Author

hr1shu commented Oct 28, 2021

IMG_20211028_193710.jpg

You're giving us hactoberfest approved label 🏷️ but the rule says it should be hacktoberfest-accepted label. Plz look into it, I've attached the image. If I'm wrong let me know @prathimacode-hub .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest

2 participants