-
- Notifications
You must be signed in to change notification settings - Fork 263
Rock Paper Scissors Game in GUI #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add PR template provide along with details mentioned here both issue number and things you had done. Add file names in appropriate format given. Your project file has no comments. Add comments to get good understanding of the code. README lacks information. There is a README template provided. Output screenshot is must and include it in README file. Go through all the details needed. Project structure mentions every detail. @SinghalChinmay |
sure @prathimacode-hub I'll do it, sorry for the inconvenience |
@prathimacode-hub I have updated the changes as told by you, do tell me if any issue arises |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README has no details. Kindly work on it. README template is provided.
Keep your project folder as "Rock Paper Scissors" and project file name as "rock_paper_scissors.py" @SinghalChinmay
@prathimacode-hub I have updated the README.md, I hope I have fixed the changes as you wanted! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see any changes in your README file. Check if its pushed properly. @SinghalChinmay
Yeah @prathimacode-hub , I just pushed one more update to README.md, which showed here, but didn't reflect in the commits tab, idk why is this happening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README needs more detailing, kindly refer to README template provided for reference. @SinghalChinmay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you done the changes? @SinghalChinmay
Yes @prathimacode-hub , I did some changes, please check if they are correct as per you or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR approved. Welcome to repo officially.👏@SinghalChinmay
Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️ |
Hey there, thanks!! |
I have created this rock paper scissors game using the Tkinter library, In this game, you basically click the button i.e Rock Paper Scissors buttons, and then get the output of win/loss/draw in the below text box
Closes : #1036
ScreenShots -


Type of Change -
Check List -
Define You -