Skip to content

Conversation

SinghalChinmay
Copy link
Contributor

@SinghalChinmay SinghalChinmay commented Oct 11, 2021

I have created this rock paper scissors game using the Tkinter library, In this game, you basically click the button i.e Rock Paper Scissors buttons, and then get the output of win/loss/draw in the below text box
Closes : #1036

ScreenShots -
rps
result

Type of Change -

  • New Feature

Check List -

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Define You -

  • Hacktoberfest2021 Participant
  • Contributor
@prathimacode-hub
Copy link
Owner

Add PR template provide along with details mentioned here both issue number and things you had done. Add file names in appropriate format given. Your project file has no comments. Add comments to get good understanding of the code. README lacks information. There is a README template provided. Output screenshot is must and include it in README file. Go through all the details needed. Project structure mentions every detail. @SinghalChinmay

@SinghalChinmay
Copy link
Contributor Author

Add PR template provide along with details mentioned here both issue number and things you had done. Add file names in appropriate format given. Your project file has no comments. Add comments to get good understanding of the code. README lacks information. There is a README template provided. Output screenshot is must and include it in README file. Go through all the details needed. Project structure mentions every detail. @SinghalChinmay

sure @prathimacode-hub I'll do it, sorry for the inconvenience

@SinghalChinmay
Copy link
Contributor Author

@prathimacode-hub I have updated the changes as told by you, do tell me if any issue arises

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README has no details. Kindly work on it. README template is provided.
Keep your project folder as "Rock Paper Scissors" and project file name as "rock_paper_scissors.py" @SinghalChinmay

@SinghalChinmay
Copy link
Contributor Author

@prathimacode-hub I have updated the README.md, I hope I have fixed the changes as you wanted!

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any changes in your README file. Check if its pushed properly. @SinghalChinmay

@SinghalChinmay
Copy link
Contributor Author

Yeah @prathimacode-hub , I just pushed one more update to README.md, which showed here, but didn't reflect in the commits tab, idk why is this happening

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README needs more detailing, kindly refer to README template provided for reference. @SinghalChinmay

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you done the changes? @SinghalChinmay

@SinghalChinmay
Copy link
Contributor Author

Yes @prathimacode-hub , I did some changes, please check if they are correct as per you or not.

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. Welcome to repo officially.👏@SinghalChinmay

@prathimacode-hub prathimacode-hub added HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest labels Oct 31, 2021
@prathimacode-hub prathimacode-hub merged commit 2243062 into prathimacode-hub:main Oct 31, 2021
@welcome
Copy link

welcome bot commented Oct 31, 2021

Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️

@SinghalChinmay
Copy link
Contributor Author

Hey there, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest

2 participants