Skip to content

Conversation

Ashi-00
Copy link
Contributor

@Ashi-00 Ashi-00 commented Oct 9, 2021

Please review and merge my PR
and don't forget to add the Hacktoberfest label! :)
Thankyou

@welcome
Copy link

welcome bot commented Oct 9, 2021

Hello there! 👋 Welcome to the project! 💖
Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄

Feel free to get in touch with me through social media handles. Hope to see you there!😄

@Ashi-00
Copy link
Contributor Author

Ashi-00 commented Oct 9, 2021

pls do review my PR @prathimacode-hub ma'am :)

@prathimacode-hub
Copy link
Owner

First create an issue and get it assigned. Add proper PR template along with your issue number. That's when PR will be reviewed. Follow the project structure as well. @Ashi-00

@Ashi-00
Copy link
Contributor Author

Ashi-00 commented Oct 12, 2021

Okay so i will first create an issue then... So i'll just close this pr and create it again after the issue gets assigned!

@prathimacode-hub
Copy link
Owner

Let this be this way. You can do it with this PR open and do the changes over this PR itself. @Ashi-00

@Ashi-00
Copy link
Contributor Author

Ashi-00 commented Oct 12, 2021

Okayy...i'll give it a try! :)

@Ashi-00
Copy link
Contributor Author

Ashi-00 commented Oct 13, 2021

Madlibs_Game

-Completes a preformed story using inputs from the user

  • Hacktoberfest2021 Participant
  • Contributor

Closes: #1048 Issue

Describe the changes you've made

Added the folder MADLIBS_Game

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This has been tested on a python IDE

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.
@Ashi-00
Copy link
Contributor Author

Ashi-00 commented Oct 13, 2021

Created the issue, added the PR Template and the README Template..Please review! @prathimacode-hub

Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done :

Add output screenshots in "Images" folder in this project
And add these links in README.md
In your project files, add comments to your code to get good understanding of it.
And keep your project folder as "MADLIBS Game"

Kindly do these changes. @Ashi-00

@Ashi-00
Copy link
Contributor Author

Ashi-00 commented Oct 13, 2021

okay i'll do them!

@Ashi-00
Copy link
Contributor Author

Ashi-00 commented Oct 14, 2021

Ma'am i have made the changes..please review!

@Ashi-00 Ashi-00 changed the title Added a folder "MADLIBS_Game" Added a folder "MADLIBS Game" Oct 14, 2021
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. Great job. 👌✔@Ashi-00

@prathimacode-hub prathimacode-hub added HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest labels Oct 14, 2021
@prathimacode-hub prathimacode-hub merged commit 48fa744 into prathimacode-hub:main Oct 14, 2021
@welcome
Copy link

welcome bot commented Oct 14, 2021

Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️

@Ashi-00
Copy link
Contributor Author

Ashi-00 commented Oct 14, 2021

Thankyou soo much ma'am!! :D @prathimacode-hub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest

2 participants