Skip to content

RANDOM PASSWORD CLASSIFIER #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 10, 2021
Merged

RANDOM PASSWORD CLASSIFIER #1028

merged 6 commits into from
Oct 10, 2021

Conversation

yashh18
Copy link
Contributor

@yashh18 yashh18 commented Oct 6, 2021 •
edited by prathimacode-hub
Loading

Related Issue

A python script problem about random password classifier

  • Hacktoberfest2021 Participant
  • Contributor

Closes: #1029

Describe the changes you've made

Made a random password generator

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This can be tested on a Python IDE

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly whereever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.
@welcome
Copy link

welcome bot commented Oct 6, 2021

Hello there! 👋 Welcome to the project! 💖
Thank you and congrats 🎉 for opening your first pull request. Please adhere to our Code of Conduct. 🙌🏻 We will get back to you as soon as we can. 😄

Feel free to get in touch with me through social media handles. Hope to see you there!😄
@prathimacode-hub
Copy link
Owner

Follow the PR template and add your issue number along with it to check on with the PR. @yashh18
prathimacode-hub
prathimacode-hub requested changes Oct 9, 2021
View reviewed changes
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the readme file as README.md
And README.md should be more elaborative. You can refer to template. @yashh18
@yashh18
Copy link
Contributor Author

yashh18 commented Oct 9, 2021

@prathimacode-hub I followed the template, made it a bit more elaborative and changed the readme to uppercase too. Please review it once again !
@prathimacode-hub prathimacode-hub added the HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 label Oct 10, 2021
prathimacode-hub
prathimacode-hub approved these changes Oct 10, 2021
View reviewed changes
Copy link
Owner

@prathimacode-hub prathimacode-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved. Amazing. 👏👍@yashh18
@prathimacode-hub prathimacode-hub added the HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest label Oct 10, 2021
@prathimacode-hub prathimacode-hub merged commit 6c37462 into prathimacode-hub:main Oct 10, 2021
@welcome
Copy link

welcome bot commented Oct 10, 2021

Congrats on merging your first Pull Request! 🎉 All the best for your amazing open source journey ahead. 🚀⚡️
@prathimacode-hub
Copy link
Owner

Append your name and your details in a shown format by creating a PR in CONTRIBUTORS.md over this repo @yashh18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HACKTOBERFEST This issue is applicable for Hacktoberfest 2022 HACKTOBERFEST-ACCEPTED This PR is approved and accepted for Hacktoberfest

2 participants

@yashh18 @prathimacode-hub