Add support for ZoneReflowStrategy in Add-PnPPageSection cmdlet #5097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the ZoneReflowStrategy parameter to the Add-PnPPageSection cmdlet, allowing users to control how zones are reflowed when rendering flexible layout sections.
- Adds validation attributes for ZoneEmphasis and VerticalZoneEmphasis parameters
- Introduces ZoneReflowStrategy parameter with conditional logic for flexible layout sections
- Updates documentation with new parameter details and usage examples
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Commands/Pages/AddPageSection.cs | Adds ZoneReflowStrategy parameter, validation attributes, and conditional logic for flexible layout sections |
| documentation/Add-PnPPageSection.md | Documents the new ZoneReflowStrategy parameter with examples and parameter details |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines 39 to +48
| { | ||
| page.AddSection(SectionTemplate, Order, ZoneEmphasis, VerticalZoneEmphasis); | ||
| if (SectionTemplate == CanvasSectionTemplate.FlexibleLayoutSection || SectionTemplate == CanvasSectionTemplate.FlexibleLayoutVerticalSection) | ||
| { | ||
| // Use the user-supplied ZoneReflowStrategy when adding flexible layout sections | ||
| page.AddSection(SectionTemplate, Order, ZoneEmphasis, VerticalZoneEmphasis, ZoneReflowStrategy); | ||
| } | ||
| else | ||
| { | ||
| page.AddSection(SectionTemplate, Order, ZoneEmphasis, VerticalZoneEmphasis); | ||
| } |
There was a problem hiding this comment.
[nitpick] The condition checking for flexible layout sections could be extracted into a helper method or property to improve readability and make it easier to maintain if more flexible layout section types are added in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Before creating a pull request, make sure that you have read the contribution file located at
https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md
Type
Related Issues?
Fixes #X, partially fixes #Y, mentioned in #Z, etc.
What is in this Pull Request ?
Please describe the changes in the PR.
Guidance