Skip to content

Conversation

@BRONSOLO
Copy link
Member

@BRONSOLO BRONSOLO commented Aug 9, 2014

@chriddyp wanna look this over when you get a chance.

plotlyupdate
plotlyupdate('verbose')
ploltyupdate('verbose','nocheck')

[CLEAN] space between outputted "verbose" descriptions
.gitignore Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is a folder containing test results, we might actually want to keep it in the repo, so that we can check test diffs on PRs (in the absence of something more automated)

@chriddyp
Copy link
Member

super awesome!

@chriddyp
Copy link
Member

So, how do you feel about issuing warnings if they are using an out-of-date version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, clever. if they're not equal, then local is outdated. much nicer than comparing 2-decimal placing numbers!

@BRONSOLO
Copy link
Member Author

@chriddyp Latest changes address your suggestions! tests are on the development branch if you want to run them : )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*locate

@chriddyp
Copy link
Member

sweet, this is looking good!

@chriddyp
Copy link
Member

did you update the version number?

@BRONSOLO
Copy link
Member Author

Not yet - i'll bump the version before the merge!

BRONSOLO added a commit that referenced this pull request Aug 18, 2014
@BRONSOLO BRONSOLO merged commit db0701d into master Aug 18, 2014
@BRONSOLO BRONSOLO deleted the version_update_dev branch September 1, 2014 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants