Config/creds updates #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Conflicts: plotly/plotly.m plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_10.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_11.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_12.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_14.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_15.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_17.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_20.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_28.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_29.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_31.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_33.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_35.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_40.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_41.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_42.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_43.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_5.png plotly/tests/test_saveplotlyfig_images/PlotlyImageTest_9.png
fix api.key/api.username filed deletion
plotly/loadplotlyconfig.m Outdated
Member
There was a problem hiding this comment.
>>> saveplotlyconfig('https://plot.ly', 'stream.plot.ly'); 
There was a problem hiding this comment.
the line fullfile(userhome,'.plotly','.config'); won't work on Win systems. Check the initial commits of my oo pull request. I fix this problem.
Member Author
There was a problem hiding this comment.
good catch! - i'll make the changes.
On 2014-06-11, at 9:05 AM, okomarov wrote:
In plotly/loadplotlyconfig.m:
@@ -0,0 +1,29 @@
+function config = loadplotlyconfig()
+
- userhome = getuserdir();
- plotly_config_file = fullfile(userhome,'.plotly','.config');
- % check if config exist
- if ~exist(plotly_config_file, 'file')
error('Plotly:ConfigNotFound',...['It looks like you haven''t set up your plotly '...'account configuration file yet.\nTo get started, save your '...'plotly/stream endpoint domain by calling:\n'...'>>> saveplotlycredentials(plotly_rest_url, stream_rest_url)\n\n'...—
Reply to this email directly or view it on GitHub.
Member
| looks good! just a couple of minor edits above |
Member Author
Member
| 💃 |
Member Author
| @chriddyp some fig2plotly.m fixes and signin fix for plotlysetup.m |
Member
| 💃 merge away! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@chriddyp new config/cred file handling.