Set world_readable to reflect value in config #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
plotly/plotlyfig.m Outdated
| | ||
| function sharing_value = get_sharing(obj) | ||
| config = loadplotlyconfig(); | ||
| config = config.sharing; |
Member
There was a problem hiding this comment.
This will fail if sharing is not defined. Could you check that it exists first. If it is not defined, we should check that world_readable is defined and use that. If not we should default to world_readable=true.
Contributor Author
| @BRONSOLO k made those changes. |
Member
| Cool - could you bump the version number in the |
Member
| 💃 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Addresses #100
@BRONSOLO