Feat/improved local and session storage #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…o that it works according to the documentation. Removed setSync from useSessionStorage as it is unusable. Removed a bug of saving value into storage, just after it was read from it. Added useDebounce parameter so that storage is updated instantly (it's usefull for example when saving accessToken in localStorage and reading from it rather than from ref). Fixed a bug of giving the ref as a defaultValue and saving the ref into a storage, rather than the value of a ref
…local and session storage
| Thank you, sorry for the delay, tests failing on |
| I believe I've fixed tests. It was just typescript screaming about possible undefined. |
| @pikax Could you run pipeline once again? |
| @pikax I think test failed regardless of my changes and just needs a rerun |
pikax approved these changes Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://pikax.me/vue-composable/composable/storage/localStorage.html
In current documentation,
removefunction is described as an equivalent tostorage.value = undefined, but it's false.When we set starage.value = undefined, this undefined is being stored in localStorage as 'undefined' (string), which lead to issues when reloading the app.
Another issue is when we pass a
refas adefaultValue(which is acceptable), then therefitself (object) is saved into localStorage, rather that it's value.There's also a thing that is missing for me personally and that is instant save into storage. Debounce is great but when I tried to use your library to store accessToken in localStorage I had an issue. In some requests the key was missing, so I believe that an option to fully sync storage with ref would be nice.
I also don't see any reason to provide
setSyncfunction in sessionStorage, when it's useless.I've fixed those and few other things in this pull req