Skip to content

Fix Buffer::discard must be fluent to be compatible with buffer package #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Fix Buffer::discard must be fluent to be compatible with buffer package #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions buffer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ PHP_METHOD(ByteBuffer, discard)
GUARD_SIZE(objval, size);

objval->data->discard(size);

RETURN_ZVAL(getThis(), 1, 0);
}

PHP_METHOD(ByteBuffer, slice)
Expand Down
18 changes: 18 additions & 0 deletions tests/012.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
--TEST--
Buffer fluent test
--SKIPIF--
<?php
if (!extension_loaded('buffer')) {
echo 'skip';
}
?>
--FILE--
<?php
$buffer = new PHPinnacle\Buffer\ByteBuffer('abcd');

echo $buffer->append('e')->bytes() . \PHP_EOL;
echo $buffer->discard(1)->bytes() . \PHP_EOL;
?>
--EXPECT--
abcde
bcde