This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Lexer lookahead refactor #78
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This re-works the lexer to use a buffer (
peek_bufmethod) for lookahead instead of a single byte. This allows us to use one big pattern match for most things instead of having sub-branches within each case.There's definitely a chance I've broken something, but all the existing tests pass.
I've also pulled out some of the larger cases into separate methods and factored out common number tokenization logic.
I really want to re-work how the column and line tracking is done but when I tried I ended up going down a rabbit hole, and will look at that as a separate piece.