This repository was archived by the owner on Jul 24, 2024. It is now read-only.
fix: better heredoc/nowdoc implementation #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ryangjchandler force-pushed the fix/rc/better-heredoc-nowdoc-parsing branch from 4f5e503 to eb460c0 Compare 
ryangjchandler force-pushed the fix/rc/better-heredoc-nowdoc-parsing branch from eb460c0 to 3e9bc95 Compare Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #161.
I'm returning
SyntaxErrors from the parser, but don't really care at this point. Handling the intricacies of heredocs & nowdocs in the parser is SO much easier than carrying state around inside of aStackFrameand having to mess with the borrow checker.I ran the Symfony and Laravel third party tests and there's no sign of heredoc/nowdoc errors so I'm taking that as a win.
I'm more or less praying that it's all correct and that I never have to come back to this, lol. In theory though, this code with the comments is much easier to debug going forward. Debugging errors in the lexer before was impossible, at least now all the heavy lifting is done in the parser.