Skip to content

Add PHP 8.4 support #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 17, 2024
Merged

Add PHP 8.4 support #58

merged 3 commits into from
Dec 17, 2024

Conversation

@mvorisek
Copy link
Member

@mvorisek mvorisek commented Dec 4, 2024 •
edited
Loading

WAITING ON spatie/async#236

needs https://github.com/spatie/async/blob/1.6.1/src/Runtime/ParentRuntime.php#L29 fixed first

1 test triggered 1 PHP deprecation: 1) /__w/lock/lock/vendor/spatie/async/src/Runtime/ParentRuntime.php:29 Spatie\Async\Runtime\ParentRuntime::init(): Implicitly marking parameter $autoloader as nullable is deprecated, the explicit nullable type must be used instead Triggered by: * malkusch\lock\Tests\mutex\MutexConcurrencyTest::testHighContention#flock /__w/lock/lock/tests/mutex/MutexConcurrencyTest.php:94
@mvorisek mvorisek force-pushed the php84 branch 3 times, most recently from f9ef53c to 7d7f58c Compare December 6, 2024 00:16
@mvorisek mvorisek marked this pull request as ready for review December 17, 2024 01:34
@mvorisek mvorisek merged commit 1dcf32d into master Dec 17, 2024
32 checks passed
@mvorisek mvorisek deleted the php84 branch December 17, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@mvorisek