Skip to content

Conversation

@mvorisek
Copy link
Member

@mvorisek mvorisek commented Jul 30, 2023

  • usleep supports microseconds resolution
  • Redis support milliseconds expire times

The changed method prototypes imply minor BC break if overriden, but no BC break in general, as float does accept (original) int values implicitly even with strict types.

@willemstuursma
Copy link
Contributor

Hi, thank you for this MR. I was a on a holiday, but I'll have a look!

@willemstuursma
Copy link
Contributor

Had a quick look, looks pretty fine, I'll have a closer look later this week.

Thank you, a very nice contribution!

@mvorisek mvorisek merged commit 0e9cad7 into php-lock:master Dec 3, 2024
8 checks passed
@mvorisek mvorisek deleted the float_timeout branch December 3, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants