Slot for no results added #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue3-infinite-loading-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| state.value = "loading"; | ||
| }, | ||
| async loaded() { | ||
| params.firstload = false; |
There was a problem hiding this comment.
regarding the documentation, firstload is used for a different scope.
This property is used to specify weither you want the component to handle first load or not Create an internal variable to store it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As this library is also used for lists that are filtered, then I believe it would be better to inform the user that there are no results.
This PR is for adding a new slot "noResults" for the mentioned feature.
I used already existing "firstLoad" props, but could add a new parameter "isInitialLoad" if firstLoad is not a good selection for this.
PS: showError was created for consistency.