Reader: add nil checks to prevent panics #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tonyghita force-pushed the add-nil-checks branch from 69351a6 to a97546e Compare 
| I am not sure about this. The receiver will only be nil if there is a programming error, such as ignoring the error returned when opening a database. As far as I can recall, only a few places in the Go standard library check for nil receiver, and those are almost alway places where nil is a legitimate value. |
| Yes, I think you're right. I'll close this... thanks for the library! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change adds nil checks to exported methods of
Reader, in order to prevent panics.