Netsize #17
Closed
Netsize #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Returns the resolved network size (bits) as the second parameter of Lookup
Renames Lookup to LookupNetmask, allowing a backward compatible method to take the place. Also change the parameter order, making sure error is the last return value for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This'll allow the network bits to be returned as the first parameter of the renamed
LookupNetmask, while retaining backwards compatibility withLookupI've tried to make this a non-breaking change, but with my limited knowledge of Go I could've missed something.