Allow directories in path #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ddsharpe requested changes Apr 23, 2018
| private static final String APP2_ENTRY_NAME2 = "wlsdeploy/applications/my-other-app(1).war"; | ||
| private static final String APP2_ENTRY_NAME3 = "wlsdeploy/applications/my-other-app(2).war"; | ||
| private static final String INVALID_ENTRY_NAME = "wlsdeploy/applications/does-not-exist.war"; | ||
| private static final String APP_DIR_ENTRY_NAME = "wlsdeploy/applications/my-app/"; |
Member
There was a problem hiding this comment.
Would be clearer if this entry was named "INVALID_DIR_ENTRY_NAME"
| archive.addApplication(new File(APP1_TO_ADD)); | ||
| archive.addApplication(new File(APP_DIR_TO_ADD)); | ||
| Assert.assertTrue("File not found in archive: " + APP1_ENTRY_NAME1, archive.containsFile(APP1_ENTRY_NAME1)); | ||
| //Assert.assertTrue("Path not found in archive: " + APP_DIR_ENTRY_NAME, archive.containsPath(APP_DIR_ENTRY_NAME)); |
| } | ||
| | ||
| @Test | ||
| public void testIsAFile() throws Exception { |
Member
There was a problem hiding this comment.
Please separate directory tests from file tests into new test method "testIsADir", and add assertion for directory found (positive directory test)
ddsharpe approved these changes Apr 23, 2018
ddsharpe approved these changes Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This will allow an application directory to exist in archive/model.