Added messages to the single resource bundle file and a writeInputStr… #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…eamToFile() function
ddsharpe requested changes Apr 5, 2018
| WLSDPLY-20020=Filter ID {0} is invalid | ||
| WLSDPLY-20021=Filter path {0} does not exist | ||
| WLSDPLY-20022=Error loading filter path {0} | ||
| |
Member
There was a problem hiding this comment.
Why are integration test messages in WDT? Shouldn't these be in the integration test project?
Contributor Author
There was a problem hiding this comment.
It looks like the stuff we found with ExceptionHelper.java (and exception_helper.py) using a static resource bundle name, is the reason I was getting the MissingResourceException. I will find a way to not use the get_message() function in either of those, in the weblogic-deploy-testing project.
The changes made to wlsdeploy_rb.properties can be reverted, but I still need the change to FileUtils.java to be reviewed and merged.
ddsharpe approved these changes Apr 10, 2018
ddsharpe deleted the Issue#-41,42-Additions-to-facilitate-the-weblogic-deploy-testing-project branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi Carolyn,
Can you review/approve the changes to two files I had to change in weblogic-deploy-tooling, because I need to use code from weblogic-deploy-tooling in the new weblogic-deploy-testing project I'm working on?
The details are in the comments of Issue# 41 and Issue # 42