- Notifications
You must be signed in to change notification settings - Fork 89
Wdt 644 -- output tool log file location at startup #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits Select commit Hold shift + click to select a range
d9d881d JIRA WDT-638 - Should never exit with uncaught exceptions
jwgish e2a955c JIRA WDT-638 - simplify handling of uncaught exceptions
jwgish cefd63a JIRA WDT-638 - remove unnecessary import
jwgish b0ca00e JIRA WDT-638 - separate Java and Python exception handling
jwgish 9284bc6 JIRA WDT-638 - fix typo in import statements
jwgish 3e41893 JIRA WDT-638 - catch java.lang.Exception instead of Throwable
jwgish c095f19 JIRA WDT-638 - handle sys.exit(). Ensure exception type is always pri…
jwgish 214aa7d JIRA WDT-638 - out with the camel names, in with the snake names
jwgish 448db31 WDT-644 write log file path to tool startup stdout logs
jwgish e942f00 Merge branch 'main' into WDT-644
jwgish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| | @@ -31,6 +31,7 @@ | |
| import oracle.weblogic.deploy.yaml.YamlException as JYamlException | ||
| | ||
| from wlsdeploy.exception.expection_types import ExceptionType | ||
| from wlsdeploy.util.cla_utils import CommandLineArgUtil | ||
| from wlsdeploy.util.exit_code import ExitCode | ||
| from wlsdeploy.util import tool_exit | ||
| | ||
| | @@ -195,7 +196,7 @@ def create_validate_exception(key, *args, **kwargs): | |
| """ | ||
| arg_list, error = _return_exception_params(*args, **kwargs) | ||
| arg_len = len(arg_list) | ||
| if error is not None: | ||
| if error https://github.com/jwgish/weblogic-deploy-tooling/pull/new/WDT-644is not None: | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typo? | ||
| if arg_len > 0: | ||
| ex = ValidateException(key, error, arg_list) | ||
| else: | ||
| | @@ -295,7 +296,7 @@ def create_yaml_exception(key, *args, **kwargs): | |
| elif len(arg_list) > 0: | ||
| ex = JYamlException(key, arg_list) | ||
| else: | ||
| ex = JYamlException(key) | ||
| ex = https://github.com/jwgish/weblogic-deploy-tooling/pull/new/WDT-644JYamlException(key) | ||
| There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typo? | ||
| return ex | ||
| | ||
| | ||
| | @@ -495,4 +496,4 @@ def __handle_unexpected_exception(ex, program_name, class_name, logger): | |
| # Note: since this is Python 2, it seems we can only get the traceback object via sys.exc_info, and of course only | ||
| # while in the except block handling code | ||
| logger.finer('WLSDPLY-20036', program_name, traceback.format_exception(type(ex), ex, sys.exc_info()[2])) | ||
| __log_and_exit(logger, ExitCode.ERROR, class_name) | ||
| __log_and_exit(logger, CommandLineArgUtil.PROG_ERROR_EXIT_CODE, class_name) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how the heck this got in here, and I can't figure out how to get rid of it.