remove l10n lib dependency #504
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
oracle-contributor-agreement bot added the OCA Verified 
naren2605 force-pushed the remove-l10n-lib branch 2 times, most recently from a37bf49 to b98724e Compare 
Achal1607 requested changes Nov 5, 2025
Member
Achal1607 left a comment
Achal1607 left a comment There was a problem hiding this comment.
nit: please run the formatter on localiser.ts
vscode/src/localiser.ts Outdated
| } | ||
| nbLocaleCode(){ | ||
| const vscodeLanguage = vscode.env.language; | ||
| if (!vscodeLanguage) return DEFAULT_LANGAUGE; |
Member
There was a problem hiding this comment.
nit: typo DEFAULT_LANGAUGE -> DEFAULT_LANGUAGE
This line is not changed in this PR but typo maybe from earlier changes.
Achal1607 reviewed Nov 5, 2025
naren2605 force-pushed the remove-l10n-lib branch 3 times, most recently from ee36dcb to e5d4b68 Compare Achal1607 reviewed Nov 10, 2025
Achal1607 requested changes Nov 10, 2025
naren2605 force-pushed the remove-l10n-lib branch 4 times, most recently from f7d854c to e543098 Compare Achal1607 previously approved these changes Nov 10, 2025
Member
Achal1607 left a comment
Achal1607 left a comment There was a problem hiding this comment.
nit: Please format localisation/extension.test.ts file if not already done.
Also, please squash the commits at the end.
naren2605 force-pushed the remove-l10n-lib branch from e543098 to 19682d3 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
remove l10n lib dependency and use format method in code base from l10n library repo