[ODSC_52446_52447] Get loggroups logids and compartment list #561
Conversation
oracle-contributor-agreement bot added the OCA Verified 
VipulMascarenhas requested review from mayoor, mingkang111, mrDzurb and qiuosier 
ads/aqua/deployment.py Outdated
| id=oci_model_deployment.id, | ||
| display_name=oci_model_deployment.display_name, | ||
| aqua_service_model=oci_model_deployment.freeform_tags.get(AQUA_SERVICE_MODEL), | ||
| aqua_service_model=oci_model_deployment.freeform_tags.get( |
There was a problem hiding this comment.
This should be boolean? aqua_service_model=oci_model_deployment.freeform_tags.get(AQUA_SERVICE_MODEL) is not None
There was a problem hiding this comment.
we're currently treating aqua_service_model as a string field (something like key=aqua_service_model val=llama2), which is also passed along when deployment is created. This is due to an absence of a tag field in AquaModelSummary. Would it be better to treat this as boolean and have something like tags: Dict[str, str] in the dataclass?
| 📌 Cov diff with main: 📌 Overall coverage: |
| 📌 Cov diff with main: 📌 Overall coverage: |
| 📌 Cov diff with main: 📌 Overall coverage: |
| 📌 Cov diff with main: 📌 Overall coverage: |
| 📌 Cov diff with main: 📌 Overall coverage: |
| 📌 Cov diff with main: 📌 Overall coverage: |
| AquaDeployment: | ||
| The instance of the Aqua model deployment. | ||
| """ | ||
| # add error handler |
There was a problem hiding this comment.
keeping for now, we have an action item to clean all this up once exception handler PR is finalized.
| # if not self._if_show(oci_model): | ||
| # raise AquaClientError(f"Target model {oci_model.id} is not Aqua model.") | ||
| if not self._if_show(oci_model): | ||
| raise AquaClientError(f"Target model {oci_model.id} is not Aqua model.") |
There was a problem hiding this comment.
Probably will not be able to use the AQUA name. I would suggest to have a custom error, something like NotAquaCompatibleError.
There was a problem hiding this comment.
yes, we'll update this once exception handler PR is finalized.
VipulMascarenhas deleted the ODSC-52446_52447_get_loggroup_compartment_list branch | 📌 Cov diff with main: 📌 Overall coverage: |
4 participants
Description
This PR covers the following:
Local Usage
These APIs can be tested from a local jupyter lab instance:
Get Log Groups
Get Log ids
Get compartments
To Do
Unit Tests