Skip to content

ODSC-49565/corrections in metrics calculation per horizon #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ODSC-49565/corrections in metrics calculation per horizon #414

wants to merge 1 commit into from

Conversation

@govarsha
Copy link
Contributor

@govarsha govarsha commented Nov 7, 2023

  1. When test data has more values than horizon, operator fails.
  2. When there is a horizon value missing for all series in test data, then test dataframe wont have that horizon. In the present code, that missing horizon is not removed from outputs so there is mismatch in the metrics calculation per horizon i.e; mismatch in the horizon picked from outputs and test data.
    Changes:
    outputs and test data frames should have same dates. So removed the extra dates that are not present in both test data & outputs and ensured that the dates are sorted in both dataframes so that there is no mismatch in metrics calculation.
@govarsha govarsha self-assigned this Nov 7, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 7, 2023
@govarsha govarsha closed this Nov 7, 2023
@github-actions
Copy link

github-actions bot commented Nov 7, 2023

📌 Cov diff with main:

Coverage-2%

📌 Overall coverage:

Coverage-28.45%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

1 participant

@govarsha