Run operator within "ads opctl run" #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
oracle-contributor-agreement bot added the OCA Verified 
| 📌 Cov diff with main: 📌 Overall coverage: |
ahosler approved these changes Oct 23, 2023
There was a problem hiding this comment.
Awesome work!
2 questions:
- I can run
ads operator run -f forecast.yamlorads optcl run -f forecast.yaml -b local, but notads optcl run -f forecast.yaml. Can we have a default backend? - Should we make any changes to the docs? Should we encourage users to use "opctl" over "operator"?
Neither question is critical to merging, PR looks great!
codeloop approved these changes Oct 23, 2023
| 📌 Cov diff with main: 📌 Overall coverage: |
Thanks Allen, I've addressed your comments and updated documentation. In the documentation i put some explanation the difference between running operator with I also added a few new features. The |
| 📌 Cov diff with main: 📌 Overall coverage: |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
https://jira.oci.oraclecorp.com/browse/ODSC-48941
ads opctl runcommand. This modification enables operators to be executed like other workloads within theads opctl runcommand.Example:
The all configurations will be auto prepared based on the ads config and environment variables.
However the
ads opctl runwill not support the all features supported byads operator run.BackendFactoryclass which contains the factory method to create the operator's compatible backend objects.