Skip to content

Conversation

mingkang111
Copy link
Member

@mingkang111 mingkang111 commented Dec 10, 2022

Description

This PR aims to fix the example in ads docs.

  • %use_session in dataflow-spark-magic
  • Quick start example of using PyTorch Framework.
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 10, 2022
Copy link
Member

@mayoor mayoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@@ -0,0 +1,74 @@
# For most projects, this workflow file will not need changing; you simply need

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file looks like it's setting up some sort of post commit hook or something?
It this meant to be part of this PR? It doesn't seem related to the example updates.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t add this file when I do git add and git commit. It was autogenerated. The first two lines of that file say that it just needs to be committed into my repository. I created this branch from the main branch. Should I try to remove it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main branch has this file, but none of the release branches do.
I don't have a ton of experience with github workflows, so I don't know what the consequences are of this file right now.
Did you create your branch off main or off the 2.7.x branch that you're targeting? From the commit list, it looks like you're pulling in some changes to the main branch on top of the changes you directly made to the docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the branch off main branch. But now targeting 2.7.x. I think that is the issues comes from. Let me fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

5 participants