Explanation fixes for error and output generation. #1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
codeloop requested review from VipulMascarenhas, ahosler, darenr, mayoor, mrDzurb and qiuosier as code owners 
oracle-contributor-agreement bot added the OCA Verified 
ahosler approved these changes Feb 28, 2025
ahosler previously approved these changes Feb 28, 2025
prasankh approved these changes Feb 28, 2025
ahosler reviewed Feb 28, 2025
| # Fall back to the default explanation generation method | ||
| super().explain_model() | ||
| except Exception as e: | ||
| if s_id in self.errors_dict: |
There was a problem hiding this comment.
we should make a function for this logic
log_error(self.errors, s_id, e)
ahosler approved these changes Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Explanation fixes for errors and explanation csv's, also adds the missing abs in the amlx explainer.